Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add basic multitenancy support to the dashboard #96

Merged
merged 14 commits into from
Jul 18, 2023

Conversation

nkshah2
Copy link
Contributor

@nkshah2 nkshah2 commented Jul 14, 2023

Summary of change

Problem Statement

(A few sentences about why this change is being made)

Summary of solution

(Overview of how the problem is solved by this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

Tested on all primary browsers for:

  • Chrome
    • Desktop
    • Mobile
    • Tablet
  • Safari
    • Desktop
    • Mobile
    • Tablet
  • Firefox
    • Desktop
    • Mobile
    • Tablet
  • (Optional) Tested on Safari 12 (Physical or emulator)
    • iPad
    • iPhone
  • (Optional) Tested on physical mobile and tablet device for:
    • Android
    • iOS (including iPadOS)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In src/version.ts
  • Had run npm run build
  • Had installed and ran the pre-commit hook

Remaining TODOs for this PR

  • Add label to the left of the tenant dropdown saying "Tenant ID: "
  • Add loading state for user details
  • When calling APIs that require tenant id - if no tenant id is found for the appropriate condition (recipe not enabled for example) do not call the API and show a popup with a specific message explaining why the operation is not permitted
  • User details page - add loading states. Initial load should have a minimum height so that the footer does not render on top. Subsequent user data loading should show a full screen overlay without replacing any of the content on the screen

@rishabhpoddar rishabhpoddar merged commit 65b56e2 into master Jul 18, 2023
3 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/multitenancy branch July 18, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants